In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's
table:number-columns-repeated attribute has a default value of 1,
meaning the cell spans the cell to its right. However when the

In ODF (19.679.2 of ODF 1.3), the <table:covered-table-cell> element's
table:number-columns-repeated attribute has a default value of 1,
meaning the cell spans the cell to its right. However when the XSLT import
filter converts from SpreadsheetML's ss:MergeAcross to ODF's
table:number-columns-repeated, it always inserts a <table:covered-table-cell>
element, and then adds the table:number-columns-repeated attribute only if
it is greater than 1. This breaks when ss:MergeAcross="0", because ODF's
defaulting to 1 ends up occupying an extra empty cell to the right when it
shouldn't.

Fix this by only inserting the <table:covered-table-cell> when
ss:MergeAcross > 0.

Add a test document to prove this.

Fixes #100989 - SpreadsheetML: cell with ss:MergeAcross="0" gets an extra empty cell to the right
Patch by: me

(cherry picked from commit a896732bfcd282115c06407a2f1da77694fa8d19)

show more ...

When importing SpreadsheetML ss:DateTime, import the entire value, not only the
first 19 characters.

Add a test file for this bug.

Fixes: #128554 - Office 2003 SpreadsheetML: fractional seconds are

When importing SpreadsheetML ss:DateTime, import the entire value, not only the
first 19 characters.

Add a test file for this bug.

Fixes: #128554 - Office 2003 SpreadsheetML: fractional seconds are silently
ignored during import
Patch by: me

(cherry picked from commit 195282cf3d8bfaa9e1cec43b093251d9df87f4ba)

show more ...

Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing
conversion from R1C1 style column references to our A1 style references, had a
bug where it was treating the column value

Our XSLT-based MS Office 2003 SpreadsheetML format import filter, when doing
conversion from R1C1 style column references to our A1 style references, had a
bug where it was treating the column value as 0-based, and dividing by 26 to
find the 1st letter and taking the remainder when divided by 26 for the second
letter. Those numbers are then each converted to a letter [0 = nothing,
1 = "A", 2 = "B", ..., 26 = "Z"].

However since R1C1 is 1-based, and not 0-based, this breaks for column numbers
which are multiples of 26, as 26 mod 26 = 0, so the least significant digit is
converted to nothing while the most significant digit gets incremented too
early.

Fix this by converting the column number to 0-based by subtracting 1 before
calculation, then adding 1 to the least significant digit afterwards.

Also the fact we have 2 letters limited us to a maximum of 26^2 = 676 columns,
after which column references would wrap around. Fix this too, by adding a 3rd
letter, which lets us address a maximum of 17576 columns.

Add a sample file to our unit tests.

Found by: alex dot plantema at xs4all dot nl
Patch by: me

(cherry picked from commit 577fe17932e0dec38662067d1a86e7fd6ae525b6)

show more ...

added test spreadsheet for single line comments and added it to test

updated to enable macro execution.

Refs #i112383# and #i117960#. backporting to AOO41X .

Can't cherry-pick due to file changes.

Original commit messages and links follow:

Found-by: andrew
Patch-by: Damjan Jovanovic
https://github.c

Refs #i112383# and #i117960#. backporting to AOO41X .

Can't cherry-pick due to file changes.

Original commit messages and links follow:

Found-by: andrew
Patch-by: Damjan Jovanovic
https://github.com/apache/openoffice/commit/323c350123d05cd9f450aebd421b7bfa74c331d2

i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = 'hi'),
but also caused a regression where "Line Input" is broken in single-line If statements.
This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to
immediately preceed the 'Line' token in order for that 'Line' token to be recognized a keyword instead
of a variable name. Also added FVT spreadsheet tests for 'Line' as both a variable name and as 'Line Input'.
Patch by: Damjan Jovanovic
https://github.com/apache/openoffice/commit/725d867363770a4c47c4b3c6dbe1f359c296604a

show more ...

Automated Testing backports from trunk to 4.1.x (#125)

* A file conversion test case, which includes some operations of ODF, MS OOXML, MS binary loading/saving, and PDF format exporting.

git-svn-

Automated Testing backports from trunk to 4.1.x (#125)

* A file conversion test case, which includes some operations of ODF, MS OOXML, MS binary loading/saving, and PDF format exporting.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1606622 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 64c719661291c877b7db7f727645b18019b1f321)

* When ./configure --with-package-format=installed is used, allow tests to run
from the resulting install directory instead of needing an archive.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1707966 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit eb07ef5f5735980e18a066e2c5820f1cbf111e2d)

* Fix a test that hangs on the "Do you want to save your changes?" dialog at exit.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1707970 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit bf385f73e5dc2aa1bfa43c45847d1582723850eb)

* #i126604# test framework on *BSD calls "ps" wrongly, can't find AOO to kill it if hung

On *BSD, call "ps" with "-wweo", as the "ww" is needed to produce all the columns in the output.
Without it, output is trimmed short, and the test framework can't find AOO to kill it,
leaving AOO running and causing further tests to fail.

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1710472 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 8716daac47832a8aecd6ba509a7944c5ea3edb11)

* Remove an erroneous tab that ends the output of "./run --help" for our
qa tests.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1733544 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit fcce20141d66b8aac0ad61b2fa3c8e44593db624)

* Fix an index out of range error in the bvt.gui.FileExport test,
which could never possibly work as the directory being
searched for isn't in the path.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1733545 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 21ba21a9c763d73402c107c84edd24a1e5dacef2)

* Path separator fixes for the bvt.gui.FileExport test.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1733549 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 126941563920c285023d1f6559a20f4a22ed64e1)

* Hide 2 utility classes that falsely register as failing tests.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1733554 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 9c5183b9128ae5fa95a129746e5d9e3fc803f184)

* Fix the failing bvt.gui.BasicFunctionTest.testFunctionWizardInFormulaBar
test method, which was failing because of use of inputKeys() instead of
typeKeys().

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1733558 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit f9b065480691d651ce3264ccd86265571a8aeb10)

* Some fixes to build.xml for qa tests:
* Fix the default ${openoffice.home} for *nix (the final "program" directory
is wrong).
* Windows uses the "OpenOffice 4" directory instead of "openoffice4".

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1737135 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 29b55262d99649dfcf0ad7da57989d4d45b4d561)

* When otherwise absent, get the run and run.bat scripts to try to detect
and use the ${openoffice.home} that the --with-package-format="installed"
option to ./configure provided.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1737137 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 70ab24e9c6201be8c04128ee171d9d3f106700d1)

* Sleep 1 second after sending Tab+Enter, as the UI needs time to
perform that action before we can copy the text out of the box.
If we don't wait then the wrong thing gets copied (a picture box
instead of the text in it), and as a text value it becomes an
empty string, and tests fail.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1814885 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit b3fee99c19b41b78a1316b1138346d2ff4cb67af)

* Fix an fvt test that was failing because long and java.lang.Integer
can't be compared.

Patch by: me

git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1814889 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 457d9638ad4f68db7c30e0ce6eb3792a1384b089)

* Explain format of "-tm" parameter when it's wrong.

Patch by: me

(cherry picked from commit 3705dcbca917f01156f9b8d7e49186e5358fb78b)

* Fix a test timing issue, and deal with "Save changes" dialog.

Patch by: me

(cherry picked from commit fbeee538df5958e9c8ad230af896b4c8175ab763)

* Fix another test timing issue.

Patch by: me

(cherry picked from commit 557ccdce2ed90616cf241d2123da4f80f65e7c70)

* RotateAngle is a java.lang.Long

Patch by: me

(cherry picked from commit 0eabae982571a4b36cda4dad5508e00553ddfa53)

* java.util.Calendar's MONTH is 0-based.

Patch by: me

(cherry picked from commit d917f5e50e8747870854d4ad71be7f834cc09fd3)

* java.util.Calendar's HOUR is a 12 hour clock, use HOUR_OF_DAY instead.

Patch by: me

(cherry picked from commit 7b7d1fc921ba2302ad7151595f2580263add807a)

* We don't need the process environment, and on FreeBSD's ps
there is apparently a total output line string length limit
of 2048 bytes that causes us to sometimes not find the
AOO pid, so leave it out.

Patch by: me

(cherry picked from commit 74bd90983f3b030e16b5ca81adac546fd0b6b285)

* Test hangs indefinitely on a link update confirmation dialog,
and I couldn't find how to confirm the dialog programmatically,
so at least make it time out instead of hanging
the whole test run.

Patch by: me

(cherry picked from commit b554e61d4a216798d7a7b23d9f8fa51b42aef9bb)

* Fix a classic bug that was breaking all registry modifications during tests,
where the return value of a string change method was not getting assigned
anywhere, and the original read-only string was expected to be the
one changed.

Patch by: me

(cherry picked from commit 5045dcc653b31c87d6b268d887ec5821c03a2dec)

* Add the registry modification that will disable clearing user personal
info on saving, so that saving and reloading fields like revision number
can be tested.

Closes #i128398# - autotest fvt.uno.sd.file.CheckFileProperties loses some DocumentProperties when saving

Patch by: me

(cherry picked from commit ce8ed6d52e206eeb0bf9eb7547f3b52546514d5e)

* Allow for tested editing time to be a little longer than expected.

Patch by: me

(cherry picked from commit 13ae91bf77e0f3b925db7293580c0ad450ab5530)

* Typo.

Patch by: me

(cherry picked from commit ff9157e3c2e6eea1bdfb12a088bffba652a52002)

* Deal with a test that expects strikeout style (X, /, bold, etc.)
to be preserved when saving to .doc, even though neither
the fileformat, nor apparently MS Office itself, support that.

Closes i120656 - the bold,with / and with X strike through change to single when save to doc

Patch by: me

(cherry picked from commit 4e588b9e25e0ea797c0e7d78b564a1b48a56819e)

Co-authored-by: Steve Yin <steve_y@apache.org>
Co-authored-by: Damjan Jovanovic <damjan@apache.org>
Co-authored-by: asf-sync-process <asf-sync-process@unknown>
Co-authored-by: damjan <damjan@13f79535-47bb-0310-9956-ffa450edef68>

show more ...

#i124310# fix autotest fvt.uno.sd.bullet.GraphicBulletFromFile

the assumption that the property "GraphicURL" is at index 6 and the
property "NumberingType" is at index 0 is not correct. The fix find

#i124310# fix autotest fvt.uno.sd.bullet.GraphicBulletFromFile

the assumption that the property "GraphicURL" is at index 6 and the
property "NumberingType" is at index 0 is not correct. The fix finds
and uses their respective indices.


git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1571617 13f79535-47bb-0310-9956-ffa450edef68

show more ...