pre-commit auto remove trailing whitespace from cxx files (#383)Another big auto clean up. So many lines !!Another one bites the dusthttps://www.youtube.com/watch?v=rY0WxgSXdEECo-authored-by:
pre-commit auto remove trailing whitespace from cxx files (#383)Another big auto clean up. So many lines !!Another one bites the dusthttps://www.youtube.com/watch?v=rY0WxgSXdEECo-authored-by: Matthias Seidel <mseidel@apache.org>(cherry picked from commit cf6516809c57e1bb0a940545cca99cdad54d4ce2)
show more ...
pre-commit auto remove trailing whitespace from XML files (#384)Auto cleaned up all the XML files for unneeded trailing whitespace.Around 8k lines changed a smaller whitespace PR this time(cher
pre-commit auto remove trailing whitespace from XML files (#384)Auto cleaned up all the XML files for unneeded trailing whitespace.Around 8k lines changed a smaller whitespace PR this time(cherry picked from commit b3b486c6f12b7baba6a5d71c7012f6454f487e5a)
pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our co
pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our code baseThe NeverEnding Story was a great film back in the old days :)Great video and theme song by Limahlhttps://www.youtube.com/watch?v=lHytjEj7B9ghttps://en.wikipedia.org/wiki/The_NeverEnding_Story_(film)(cherry picked from commit 914d351e5f5b84e4342a86d6ab8d4aca7308b9bd)
Cleanup(cherry picked from commit 013b951efd287fdc278c680b1adeb3413cf91cae)
misc: fix spelling (#359)* misc: fix spelling* Update ignored words list* Update propshlp.cxx---------Co-authored-by: Matthias Seidel <mseidel@apache.org>(cherry picked from commit 565bea5
misc: fix spelling (#359)* misc: fix spelling* Update ignored words list* Update propshlp.cxx---------Co-authored-by: Matthias Seidel <mseidel@apache.org>(cherry picked from commit 565bea5d874efc40bc68a4981c2c2749fbc88f2d)
Cleanup(cherry picked from commit b3897e6aa10c44e4a3a28a6e1f45e38816be3d7f)
misc: fix spelling in `main` (#354)* misc: fix spelling in `main`Typos have been fixed in a lot of file types* Update ignored words list(cherry picked from commit ad1df53dc2d3caa51ab9151d59e6
misc: fix spelling in `main` (#354)* misc: fix spelling in `main`Typos have been fixed in a lot of file types* Update ignored words list(cherry picked from commit ad1df53dc2d3caa51ab9151d59e6525b81e52754)
Fix spelling (#329)* Fix spelling* Update ignore words list(cherry picked from commit d941b70c83dc1cf56dc95264273f8a288e742c24)
pre-commit(end-of-file-fixer): autofix more cxx files in main (#317)(cherry picked from commit 42f9d71d141b0d481f7c3a24ca2c8090c33520f4)
Fix spelling (#247)(cherry picked from commit ca0014a11564db4404ca1428d5cd6d6bb96e2c25)
Fix spelling (#231)(cherry picked from commit d41c82aed43ad4a58d6e39ecd99937fe437857e8)
Fix spelling in comments (#209)(cherry picked from commit cdfa2a0e248945df34d583b6091f49e81274c41e)
Fixed typos (Normaly -> Normally) and some more(cherry picked from commit 2e3a1b6e4abf6df35dae2c3095e845de0304e209)
Fixed typos (the the -> the) and some more(cherry picked from commit 7950f2af818787db817abe90d4dbb3d6d8409899)
Fixed typos: contructor -> constructor convinient -> convenientgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1832633 13f79535-47bb-0310-9956-ffa450edef68
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"t
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"this" will never be null, so a compiler could legally optimize outthis comparision, which could potentially result in the methoddereferencing a null pointer later in the code. This situationcould only happen if the caller is using a null object pointer tocall the method or is using a object ref to call the method thatwas generated by dereferencing a null pointer, neither of which isvalid. Resolve this by moving the checks out of the method andinto the caller.Make this easier by changing the getImpl() method to return the private *Impl pointer directly instead of deferencing the pointerand returning a ref. The latter is invalid if the pointer is null.This allows GetImpl() to be called in a boolean contect to peformthe check. It also allows a number of instances of "&getImpl()"calls in a boolean context to be fixed by changing them to "getImpl()".The address of a ref will never be zero in a valid C++ program, so the compiler could potentially optimize out those checks.There does not appear to be any need for Control and ComboBox to use customized versions of GetImpl() since these appear to behaveidentically to the versions generated by the canned macro, so switchthem back to the macro version.This commit should result in no functional changes.It seems like all of these checks for a null implementation shouldnot be necessary, but that requires further investigation.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744 13f79535-47bb-0310-9956-ffa450edef68
#i98216# extract boolean value for AutoFill value of ComboBox modelgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1595141 13f79535-47bb-0310-9956-ffa450edef68
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the internationa
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the international nature of the code butit is somewhat shameful that this wasn't done before.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68
#i123817# prepare codebase for updating to boost 1.55git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555789 13f79535-47bb-0310-9956-ffa450edef68
#i123963# remove type ambiguity in toolkit's VCLXDevicegit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555077 13f79535-47bb-0310-9956-ffa450edef68
#120358# apply patch to support properties from tab modelPatch By: hanyaReview By: jsc git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1552621 13f79535-47bb-0310-9956-ffa450edef68
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces gratuitouscomplexity especially when debugging stacks where both types are used.The names of NSView type variables have been adjusted too.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1547078 13f79535-47bb-0310-9956-ffa450edef68
#i123068# remove implicit conversions from rtl strings to their elementsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546390 13f79535-47bb-0310-9956-ffa450edef68
#i123768# [ia2] remove pseudo-automatic noisy commentsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546355 13f79535-47bb-0310-9956-ffa450edef68
123