pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our co
pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our code baseThe NeverEnding Story was a great film back in the old days :)Great video and theme song by Limahlhttps://www.youtube.com/watch?v=lHytjEj7B9ghttps://en.wikipedia.org/wiki/The_NeverEnding_Story_(film)
show more ...
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"t
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"this" will never be null, so a compiler could legally optimize outthis comparision, which could potentially result in the methoddereferencing a null pointer later in the code. This situationcould only happen if the caller is using a null object pointer tocall the method or is using a object ref to call the method thatwas generated by dereferencing a null pointer, neither of which isvalid. Resolve this by moving the checks out of the method andinto the caller.Make this easier by changing the getImpl() method to return the private *Impl pointer directly instead of deferencing the pointerand returning a ref. The latter is invalid if the pointer is null.This allows GetImpl() to be called in a boolean contect to peformthe check. It also allows a number of instances of "&getImpl()"calls in a boolean context to be fixed by changing them to "getImpl()".The address of a ref will never be zero in a valid C++ program, so the compiler could potentially optimize out those checks.There does not appear to be any need for Control and ComboBox to use customized versions of GetImpl() since these appear to behaveidentically to the versions generated by the canned macro, so switchthem back to the macro version.This commit should result in no functional changes.It seems like all of these checks for a null implementation shouldnot be necessary, but that requires further investigation.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68
Update headers to Alv2 headersgit-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1198492 13f79535-47bb-0310-9956-ffa450edef68
Initial import of the old OOo hg repository tip revision. .../trunk/main is a copy of (currently tip-most) http://hg.services.openoffice.org/OOO340/rev/c904c1944462 .../trunk/extras/l10n is a co
Initial import of the old OOo hg repository tip revision. .../trunk/main is a copy of (currently tip-most) http://hg.services.openoffice.org/OOO340/rev/c904c1944462 .../trunk/extras/l10n is a copy of (currently tip-most) http://hg.services.openoffice.org/master_l10n/OOO340/rev/af6bc9467af5 Note that the following files with line-end and/or encoding anomalies were left out (they will need to be to be checked in separately):/ooo/trunk/core/dictionaries/de_DE/README_hyph_de_DE.txt/ooo/trunk/core/dictionaries/de_CH/README_hyph_de_CH.txt/ooo/trunk/core/dictionaries/de_AT/README_hyph_de_AT.txt/ooo/trunk/core/gettext/gettext-0.18.1.1.patch/ooo/trunk/core/apache-commons/patches/codec.patch/ooo/trunk/core/libcroco/libcroco-0.6.2.patch/ooo/trunk/core/testautomation/writer/optional/input/import/mactext.txt/ooo/trunk/core/graphite/graphite-2.3.1.patch/ooo/trunk/core/hwpfilter/source/hwpeq.cpp/ooo/trunk/core/solenv/bin/cwstouched.pl/ooo/trunk/core/readlicense_oo/html/THIRDPARTYLICENSEREADME.html/ooo/trunk/core/writerfilter/source/doctok/escher.html/ooo/trunk/core/writerfilter/source/odiapi/qname/resource/office2003/WordprocessingML Schemas/xsdlib.xsd/ooo/trunk/core/writerfilter/source/odiapi/qname/resource/office2003/WordprocessingML Schemas/wordnetaux.xsd/ooo/trunk/core/filter/source/xslt/odf2xhtml/export/common/body.xsl/ooo/trunk/core/filter/source/xslt/odf2xhtml/export/common/styles/style_mapping_css.xslAlso: Repository.mk from the l10n toplevelgit-svn-id: https://svn.apache.org/repos/asf/incubator/ooo/trunk@1162288 13f79535-47bb-0310-9956-ffa450edef68