pre-commit auto remove trailing whitespace from cxx files (#383)Another big auto clean up. So many lines !!Another one bites the dusthttps://www.youtube.com/watch?v=rY0WxgSXdEECo-authored-by:
pre-commit auto remove trailing whitespace from cxx files (#383)Another big auto clean up. So many lines !!Another one bites the dusthttps://www.youtube.com/watch?v=rY0WxgSXdEECo-authored-by: Matthias Seidel <mseidel@apache.org>
show more ...
pre-commit auto remove trailing whitespace from XML files (#384)Auto cleaned up all the XML files for unneeded trailing whitespace.Around 8k lines changed a smaller whitespace PR this time
pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our co
pre-commit auto clean trailing whitespace in dxp and hxx files (#381)A huge auto clean up by pre-commit and I can make smaller PRs if needed.Seems we have a lot of extra whitespace junk in our code baseThe NeverEnding Story was a great film back in the old days :)Great video and theme song by Limahlhttps://www.youtube.com/watch?v=lHytjEj7B9ghttps://en.wikipedia.org/wiki/The_NeverEnding_Story_(film)
Cleanup
misc: fix spelling (#359)* misc: fix spelling* Update ignored words list* Update propshlp.cxx---------Co-authored-by: Matthias Seidel <mseidel@apache.org>
misc: fix spelling in `main` (#354)* misc: fix spelling in `main`Typos have been fixed in a lot of file types* Update ignored words list
Fix spelling (#329)* Fix spelling* Update ignore words list
pre-commit(end-of-file-fixer): autofix more cxx files in main (#317)
Fix spelling (#247)
Fix spelling (#231)
Fix spelling in comments (#209)
Fixed typos (Normaly -> Normally) and some more
Fixed typos (the the -> the) and some more
Fixed typos: contructor -> constructor convinient -> convenientgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1832633 13f79535-47bb-0310-9956-ffa450edef68
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"t
A number of methods in main/toolkit/source/layout/vcl/* use either"!this" or "this" in a boolean context in order to detect beingcalled with a null object and exit early. In a valid C++ program"this" will never be null, so a compiler could legally optimize outthis comparision, which could potentially result in the methoddereferencing a null pointer later in the code. This situationcould only happen if the caller is using a null object pointer tocall the method or is using a object ref to call the method thatwas generated by dereferencing a null pointer, neither of which isvalid. Resolve this by moving the checks out of the method andinto the caller.Make this easier by changing the getImpl() method to return the private *Impl pointer directly instead of deferencing the pointerand returning a ref. The latter is invalid if the pointer is null.This allows GetImpl() to be called in a boolean contect to peformthe check. It also allows a number of instances of "&getImpl()"calls in a boolean context to be fixed by changing them to "getImpl()".The address of a ref will never be zero in a valid C++ program, so the compiler could potentially optimize out those checks.There does not appear to be any need for Control and ComboBox to use customized versions of GetImpl() since these appear to behaveidentically to the versions generated by the canned macro, so switchthem back to the macro version.This commit should result in no functional changes.It seems like all of these checks for a null implementation shouldnot be necessary, but that requires further investigation.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1823225 13f79535-47bb-0310-9956-ffa450edef68
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744
#i98734# store and load ScaleMode property of image control on dialogsSuggested by: Frank Schönheit <frank.schoenheit@gmx.de>git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1654744 13f79535-47bb-0310-9956-ffa450edef68
#i98216# extract boolean value for AutoFill value of ComboBox modelgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1595141 13f79535-47bb-0310-9956-ffa450edef68
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the internationa
Many spelling fixes: directories r* - z*.Attempt to clean up most but certainly not all the spellingmistakes that found home in OpenOffice through decades. Wecould probably blame the international nature of the code butit is somewhat shameful that this wasn't done before.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1591062 13f79535-47bb-0310-9956-ffa450edef68
#i123817# prepare codebase for updating to boost 1.55git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555789 13f79535-47bb-0310-9956-ffa450edef68
#i123963# remove type ambiguity in toolkit's VCLXDevicegit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1555077 13f79535-47bb-0310-9956-ffa450edef68
#120358# apply patch to support properties from tab modelPatch By: hanyaReview By: jsc git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1552621 13f79535-47bb-0310-9956-ffa450edef68
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces
#i123795# variable names should not confuse vcl Window and cocoa NSWindow typesVCL's Window type and Cocoa's NSWindow type are quite different.Naming variables as if they were the same introduces gratuitouscomplexity especially when debugging stacks where both types are used.The names of NSView type variables have been adjusted too.git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1547078 13f79535-47bb-0310-9956-ffa450edef68
#i123068# remove implicit conversions from rtl strings to their elementsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546390 13f79535-47bb-0310-9956-ffa450edef68
#i123768# [ia2] remove pseudo-automatic noisy commentsgit-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1546355 13f79535-47bb-0310-9956-ffa450edef68
123