| ccdf8a55 | 08-Jun-2026 |
Jim Jagielski <jimjag@gmail.com> |
Fix crash, uninitialized-return, and buffer bugs in update check and macOS x86 bridge
updateprotocol.cxx: guard XNodeList dereferences so a swallowed XPathException no longer leaves a null reference
Fix crash, uninitialized-return, and buffer bugs in update check and macOS x86 bridge
updateprotocol.cxx: guard XNodeList dereferences so a swallowed XPathException no longer leaves a null reference to be dereferenced (crash on malformed/hostile update descriptors); clear the list before the relnote query so a thrown exception can't leave us iterating the previous (sources) node list.
cpp2uno.cxx: the queryInterface fast-path guard used 'break', which exited the switch and skipped the default case, returning an uninitialized typelib_TypeClass. Guard the block with 'if (bHasHiddenReturn)' instead so control falls through to default and eRet is always assigned.
updatecheck.cxx (getImageFromFileName): use bitwise '|' instead of logical '||' when combining osl_Process flags; rewrite the trailing CR/LF trim so it never reads/writes before the start of the buffer (e.g. when osl_readFile returns 0 bytes).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
show more ...
|